Add ParquetExec::builder(), deprecate ParquetExec::new
#10636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/parquet_builder
branch
4 times, most recently
from
6cefd61
to
313252e
Compare
alamb
force-pushed
the
alamb/parquet_builder
branch
from
c6a0dab
to
9c100e4
Compare
alamb
force-pushed
the
alamb/parquet_builder
branch
from
9c100e4
to
f4bccc2
Compare
alamb
changed the title
ParquetExec::builder APIParquetExec::builder(), deprecate ParquetExec::new
waynexia
approved these changes
May 29, 2024
|
Thanks @waynexia !
I added what I think you are referring to in 70a14dc (though I am not quite sure). Let me know if you had a different idea and I will make that change. |
|
But after some search, I realized that |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #10546
Rationale for this change
While working on #10549 it cumbersome to create a
ParquetExec-- there are a few fields onParquetExec::newthat need default values that make it slightly confusing to use.What changes are included in this PR?
ParquetExecBuilderandParquetExec::builder()that handle defaultsParquetExec::newYou can see this in action here #10618
Are these changes tested?
Yes, covered by existing tests and new doc example tests
Are there any user-facing changes?
Better docs / examples / builder.
ParquetExec::new()is now deprecated